WIP - saving expires at for sharing records

backend/src/models/record-share.model.ts

@@ -21,13 +21,13 @@ export class RecordShare extends BaseModel {
     };
   }
 
-  // Override BaseModel hooks to prevent automatic timestamp handling
-  $beforeInsert(queryContext: any) {
-    // Don't set timestamps - let database defaults handle it
+  // Don't auto-set timestamps - let DB defaults handle them
+  $beforeInsert() {
+    // Don't call super - skip BaseModel's timestamp logic
   }
 
-  $beforeUpdate(opt: any, queryContext: any) {
-    // Don't set timestamps - let database defaults handle it
+  $beforeUpdate() {
+    // Don't call super - skip BaseModel's timestamp logic
   }
 
   id!: string;

backend/src/rbac/record-sharing.controller.ts

@@ -147,39 +147,43 @@ export class RecordSharingController {
 
     if (existingShare) {
       // Update existing share
-      await knex('record_shares')
-        .where({ id: existingShare.id })
-        .update({
-          accessLevel: JSON.stringify({
+      const updated = await RecordShare.query(knex)
+        .patchAndFetchById(existingShare.id, {
+          accessLevel: {
             canRead: data.canRead,
             canEdit: data.canEdit,
             canDelete: data.canDelete,
-          }),
-          expiresAt: data.expiresAt ? data.expiresAt : null,
-          updatedAt: knex.fn.now(),
-        });
+          },
+          // Convert ISO string to MySQL datetime format
+          expiresAt: data.expiresAt 
+            ? knex.raw('?', [new Date(data.expiresAt).toISOString().slice(0, 19).replace('T', ' ')]) 
+            : null,
+        } as any);
 
       return RecordShare.query(knex)
-        .findById(existingShare.id)
+        .findById(updated.id)
         .withGraphFetched('[granteeUser]');
     }
 
     // Create new share
-    const [shareId] = await knex('record_shares').insert({
+    const share = await RecordShare.query(knex).insertAndFetch({
       objectDefinitionId: objectDef.id,
       recordId,
       granteeUserId: data.granteeUserId,
       grantedByUserId: currentUser.userId,
-      accessLevel: JSON.stringify({
+      accessLevel: {
         canRead: data.canRead,
         canEdit: data.canEdit,
         canDelete: data.canDelete,
-      }),
-      expiresAt: data.expiresAt ? data.expiresAt : null,
-    });
+      },
+      // Convert ISO string to MySQL datetime format: YYYY-MM-DD HH:MM:SS
+      expiresAt: data.expiresAt 
+        ? knex.raw('?', [new Date(data.expiresAt).toISOString().slice(0, 19).replace('T', ' ')]) 
+        : null,
+    } as any);
 
     return RecordShare.query(knex)
-      .findById(shareId)
+      .findById(share.id)
       .withGraphFetched('[granteeUser]');
   }
 
@@ -235,11 +239,9 @@ export class RecordSharingController {
     }
 
     // Revoke the share (soft delete)
-    await knex('record_shares')
-      .where({ id: shareId })
-      .update({
-        revokedAt: knex.fn.now(),
-        updatedAt: knex.fn.now(),
+    await RecordShare.query(knex)
+      .patchAndFetchById(shareId, {
+        revokedAt: knex.fn.now() as any,
       });
 
     return { success: true };

frontend/components/RecordSharing.vue

@@ -146,14 +146,15 @@
 
           <div class="space-y-2">
             <Label for="expiresAt">Expires At (Optional)</Label>
-            <Input
-              id="expiresAt"
-              v-model="newShare.expiresAt"
-              type="datetime-local"
-              placeholder="Never"
+            <div class="flex gap-2">
+              <DatePicker
+                v-model="expiresDate"
+                placeholder="Select date"
+                class="flex-1"
               />
             </div>
           </div>
+        </div>
         <DialogFooter>
           <Button variant="outline" @click="showShareDialog = false">Cancel</Button>
           <Button
@@ -178,6 +179,7 @@ import { Input } from '~/components/ui/input';
 import { Label } from '~/components/ui/label';
 import { Badge } from '~/components/ui/badge';
 import Checkbox from '~/components/ui/checkbox.vue';
+import DatePicker from '~/components/ui/date-picker/DatePicker.vue';
 import { UserPlus, Trash2, Users } from 'lucide-vue-next';
 
 interface Props {
@@ -206,6 +208,24 @@ const newShare = ref({
   expiresAt: '',
 });
 
+const expiresDate = ref<Date | null>(null);
+const expiresTime = ref('');
+
+// Computed property to combine date and time into ISO string
+const combinedExpiresAt = computed(() => {
+  if (!expiresDate.value) return '';
+  
+  const date = new Date(expiresDate.value);
+  if (expiresTime.value) {
+    const [hours, minutes] = expiresTime.value.split(':');
+    date.setHours(parseInt(hours), parseInt(minutes), 0, 0);
+  } else {
+    date.setHours(23, 59, 59, 999); // Default to end of day
+  }
+  
+  return date.toISOString();
+});
+
 // Filter out users who already have shares
 const availableUsers = computed(() => {
   const sharedUserIds = new Set(shares.value.map(s => s.granteeUserId));
@@ -244,6 +264,10 @@ const loadUsers = async () => {
 const createShare = async () => {
   try {
     sharing.value = true;
+    
+    const expiresAtValue = combinedExpiresAt.value;
+    console.log('Creating share, expiresAt value:', expiresAtValue);
+    
     const payload: any = {
       granteeUserId: newShare.value.userId,
       canRead: newShare.value.canRead,
@@ -252,10 +276,15 @@ const createShare = async () => {
     };
     
     // Only include expiresAt if it has a value
-    if (newShare.value.expiresAt && newShare.value.expiresAt.trim()) {
-      payload.expiresAt = newShare.value.expiresAt;
+    if (expiresAtValue) {
+      payload.expiresAt = expiresAtValue;
+      console.log('Including expiresAt in payload:', payload.expiresAt);
+    } else {
+      console.log('Skipping expiresAt - no date selected');
     }
     
+    console.log('Final payload:', payload);
+    
     await api.post(
       `/runtime/objects/${props.objectApiName}/records/${props.recordId}/shares`,
       payload
@@ -269,6 +298,8 @@ const createShare = async () => {
       canDelete: false,
       expiresAt: '',
     };
+    expiresDate.value = null;
+    expiresTime.value = '';
     await loadShares();
   } catch (e: any) {
     console.error('Failed to share record:', e);